Migrate typing for integrations - part 4 #4533
Merged
+417
−423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## neel/typing #4533 +/- ##
================================================
+ Coverage 33.17% 84.84% +51.67%
================================================
Files 144 144
Lines 14965 14973 +8
Branches 2374 2374
================================================
+ Hits 4964 12704 +7740
+ Misses 9514 1540 -7974
- Partials 487 729 +242
|
sentrivana
approved these changes
Jun 30, 2025
Contributor
sentrivana
left a comment
sentrivana
left a comment
There was a problem hiding this comment.
See small comment, else lgtm
sl0thentr0py
force-pushed
the
neel/typing-integrations-4
branch
from
730734d to
0474152
Compare
sl0thentr0py
force-pushed
the
neel/typing-integrations-4
branch
from
0474152 to
8d33222
Compare
sl0thentr0py
added a commit
that referenced
this pull request
Jun 30, 2025
extracted from https://github.com/getsentry/sentry-python/pull/4487/files with lots of manual fixes * migrate old style `# type: bla` to inline types * most importantly use [`__future__.annotations`](https://peps.python.org/pep-0563/#enabling-the-future-behavior-in-python-3-7) so that we can simply use forward annotations without wrapping them in strings like we did before, this simplifies things substantially * also guard only things that shouldn't be imported under `TYPE_CHECKING`, in the future it seems we should avoid using `TYPE_CHECKING` completely * #4510 * #4522 * #4529 * #4530 * #4532 * #4533 * #4534 closes #2585
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.